Skip to content

Update swap widget slippage value logic #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedromcunha merged 2 commits into from
Jul 25, 2025
Merged

Update swap widget slippage value logic #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b827a91
Display max slippage between api and user input
pedromcunha Jul 25, 2025
54e4628
feat: changeset
pedromcunha Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shaggy-ears-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@reservoir0x/relay-kit-ui': patch
---

Use max slippage between user input and quote for display
10 changes: 8 additions & 2 deletions packages/ui/src/components/widgets/FeeBreakdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ type Props = Pick<
isSingleChainLocked?: boolean
fromChainWalletVMSupported?: boolean
isAutoSlippage: boolean
slippageInputBps?: string
}

const formatSwapRate = (rate: number) => {
Expand All @@ -60,7 +61,8 @@ const FeeBreakdown: FC<Props> = ({
canonicalTimeEstimate,
isSingleChainLocked,
fromChainWalletVMSupported,
isAutoSlippage
isAutoSlippage,
slippageInputBps
}) => {
const [isOpen, setIsOpen] = useState(false)
const swapRate = quote?.details?.rate
Expand All @@ -79,12 +81,16 @@ const FeeBreakdown: FC<Props> = ({
quote?.details?.slippageTolerance?.origin?.percent
const destinationSlippageTolerance =
quote?.details?.slippageTolerance?.destination?.percent
const slippage =
const quoteSlippage =
(isSameChain
? destinationSlippageTolerance === '0'
? originSlippageTolerance
: destinationSlippageTolerance
: destinationSlippageTolerance) ?? '0'
const slippageInputNumber = Number(
(Number(slippageInputBps ?? '0') / 100).toFixed(2)
)
const slippage = `${Math.max(Number(quoteSlippage), slippageInputNumber)}`

const slippageRating = getSlippageRating(slippage)
const slippageRatingColor = ratingToColor[slippageRating]
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/components/widgets/SwapWidget/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1577,6 +1577,7 @@ const SwapWidget: FC<SwapWidgetProps> = ({
supportsExternalLiquidity={supportsExternalLiquidity}
useExternalLiquidity={useExternalLiquidity}
isAutoSlippage={isAutoSlippage}
slippageInputBps={slippageTolerance}
toChain={toChain}
setUseExternalLiquidity={(enabled) => {
setUseExternalLiquidity(enabled)
Expand Down