Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
id: test
uses: fedora-python/tox-github-action@main
with:
tox_env: py39,py313,lint
tox_env: py39,py313,lint,isort
dnf_install: >-
--repo fedora --repo updates
krb5-devel
Expand Down
3 changes: 2 additions & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#
import os
import sys

sys.path.insert(0, os.path.abspath('..'))


Expand Down Expand Up @@ -182,4 +183,4 @@
epub_exclude_files = ['search.html']


# -- Extension configuration -------------------------------------------------
# -- Extension configuration -------------------------------------------------
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110.15.0 USA
#
# Authors: Ralph Bean <rbean@redhat.com>
from setuptools import setup
import os

from setuptools import setup

with open('requirements.txt', 'rb') as f:
install_requires = f.read().decode('utf-8').split('\n')
if not os.getenv('READTHEDOCS'):
Expand Down
4 changes: 2 additions & 2 deletions sync-page/event-handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
import os

# 3rd Party Modules
from flask import Flask, render_template, request, redirect
from flask import Flask, redirect, render_template, request

# Local Modules
from sync2jira.main import load_config, initialize_pr, initialize_issues
from sync2jira.main import initialize_issues, initialize_pr, load_config

# Global Variables
app = Flask(__name__, static_url_path="/assets", static_folder="assets")
Expand Down
5 changes: 3 additions & 2 deletions sync2jira/downstream_issue.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
#
# Authors: Ralph Bean <rbean@redhat.com>

# Python Standard Library Modules
from datetime import datetime, timezone

# Python Standard Library Modules
import difflib
import logging
import operator
Comment on lines 20 to 25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These imports should all be in one block (i.e., datetime is a Standard Library module), so we should probably just remove the comment at line 22 (and line 29 and line 36) -- now that we have isort, these blocks will be maintained automatically, no there is no need to label them.

Expand All @@ -27,9 +28,9 @@

# 3rd Party Modules
import arrow
import jinja2
from jira import JIRAError
import jira.client
import jinja2
import pypandoc

# Local Modules
Expand Down
1 change: 0 additions & 1 deletion sync2jira/downstream_pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import sync2jira.downstream_issue as d_issue
from sync2jira.intermediary import Issue, matcher


log = logging.getLogger('sync2jira')


Expand Down
6 changes: 3 additions & 3 deletions sync2jira/mailer.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
This script is used to send emails
"""

import smtplib
import os
from email.mime.text import MIMEText
from email.mime.multipart import MIMEMultipart
from email.mime.text import MIMEText
import os
import smtplib

DEFAULT_FROM = os.environ.get('DEFAULT_FROM')
DEFAULT_SERVER = os.environ.get('DEFAULT_SERVER')
Expand Down
17 changes: 9 additions & 8 deletions sync2jira/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,28 +21,29 @@

Run with systemd, please.
"""
from copy import deepcopy

# Build-In Modules
import logging
import warnings
import traceback
from time import sleep
import requests
from copy import deepcopy
import os
from time import sleep
import traceback
import warnings
Comment on lines +24 to +31
Copy link
Collaborator

@webbnh webbnh Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# 3rd Party Modules
import fedmsg
import fedmsg.config
import jinja2
import requests
from requests_kerberos import HTTPKerberosAuth, OPTIONAL

# Local Modules
import sync2jira.upstream_issue as u_issue
import sync2jira.upstream_pr as u_pr
import sync2jira.downstream_issue as d_issue
import sync2jira.downstream_pr as d_pr
from sync2jira.mailer import send_mail
from sync2jira.intermediary import matcher
from sync2jira.mailer import send_mail
import sync2jira.upstream_issue as u_issue
import sync2jira.upstream_pr as u_pr

# Set up our logging
FORMAT = "[%(asctime)s] %(levelname)s: %(message)s"
Expand Down
5 changes: 2 additions & 3 deletions sync2jira/upstream_issue.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,15 @@
#
# Authors: Ralph Bean <rbean@redhat.com>

from copy import deepcopy
import logging
from urllib.parse import urlencode
from copy import deepcopy

import requests
from github import Github
import requests

import sync2jira.intermediary as i


log = logging.getLogger('sync2jira')
graphqlurl = 'https://api.github.com/graphql'

Expand Down
1 change: 0 additions & 1 deletion sync2jira/upstream_pr.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import sync2jira.intermediary as i
import sync2jira.upstream_issue as u_issue


log = logging.getLogger('sync2jira')


Expand Down
11 changes: 6 additions & 5 deletions tests/integration_tests/integration_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,17 @@
This is a helper program to listen for UMB trigger. Test and then deploy Sync2Jira
"""
# Built-In Modules
import os
import logging
import os

# 3rd Party Modules
import jira.client

# Local Modules
from sync2jira.main import main as m
from jira_values import GITHUB
from runtime_config import runtime_config

# 3rd Party Modules
import jira.client
from sync2jira.main import main as m

# Global Variables
URL = os.environ['JIRA_STAGE_URL']
Expand Down Expand Up @@ -139,4 +140,4 @@ def get_jira_client():

if __name__ == '__main__':
# Call our main method after parsing out message
main()
main()
8 changes: 4 additions & 4 deletions tests/test_downstream_issue.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
from datetime import datetime, timezone
import unittest
import unittest.mock as mock
from unittest.mock import MagicMock
from datetime import datetime, timezone

from jira import JIRAError
import jira.client

import sync2jira.downstream_issue as d
from sync2jira.intermediary import Issue

import jira.client
from jira import JIRAError

PATH = 'sync2jira.downstream_issue.'


Expand Down
1 change: 0 additions & 1 deletion tests/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import sync2jira.main as m


PATH = 'sync2jira.main.'


Expand Down
3 changes: 1 addition & 2 deletions tests/test_upstream_issue.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
from copy import deepcopy
import unittest
import unittest.mock as mock
from unittest.mock import MagicMock
from copy import deepcopy

import sync2jira.upstream_issue as u


PATH = 'sync2jira.upstream_issue.'


Expand Down
3 changes: 1 addition & 2 deletions tests/test_upstream_pr.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
from copy import deepcopy
import unittest
import unittest.mock as mock
from unittest.mock import MagicMock
from copy import deepcopy

import sync2jira.upstream_pr as u


PATH = 'sync2jira.upstream_pr.'


Expand Down
18 changes: 17 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py39,py313,lint
envlist = py39,py313,lint,isort

[testenv]
setenv =
Expand All @@ -25,3 +25,19 @@ deps =
flake8
commands =
flake8 sync2jira --max-line-length=140

[isort]
profile = black
known_first_party = ["sync2jira"]
force_sort_within_sections = true
order_by_type = false

[testenv:isort]
skip_install = true
deps = isort
commands = isort --check --diff {posargs:.}

[testenv:isort-format]
skip_install = true
deps = isort
commands = isort {posargs:.}
Loading