Conversation
Member
Author
|
This includes changes from #279. |
webbnh
previously approved these changes
Jan 24, 2025
Collaborator
webbnh
left a comment
There was a problem hiding this comment.
I'm a fan of using Black, even if I don't necessarily like everything that it does.
I've called out a few things below:
- Foremost, it looks like you included a commit on this branch which belongs in a separate PR.
- Beyond that, there are a couple of changes that Black made that I think you might want to resist in various ways.
- And, finally, the changes highlighted a couple of spots in the code where we might want to make some tweaks beyond what Black proposed...which you should feel free to decline.
Comment on lines
415
to
420
| filter( | ||
| lambda x: _find_comment_in_jira(x, j_comments) is None or x['changed'] is not None, | ||
| g_comments | ||
| ) | ||
| lambda x: _find_comment_in_jira(x, j_comments) is None | ||
| or x["changed"] is not None, | ||
| g_comments, | ||
| ) |
Collaborator
There was a problem hiding this comment.
[I don't know whether you're interested in making this sort of change, but I'll point it out and you can decline if you like....]
Since we're going to include x in the result if it is changed, we should check that before checking to see if the comment is in j_comments.
Comment on lines
+151
to
+159
| return jira.client.JIRA( | ||
| **{ | ||
| "options": { | ||
| "server": URL, | ||
| "verify": False, | ||
| }, | ||
| "token_auth": TOKEN, | ||
| } | ||
| ) |
Collaborator
There was a problem hiding this comment.
Using the ** operator on a literal is a little heavy-handed, we should do something like this, instead:
Suggested change
| return jira.client.JIRA( | |
| **{ | |
| "options": { | |
| "server": URL, | |
| "verify": False, | |
| }, | |
| "token_auth": TOKEN, | |
| } | |
| ) | |
| return jira.client.JIRA( | |
| options={ | |
| "server": URL, | |
| "verify": False, | |
| }, | |
| token_auth=TOKEN, | |
| ) |
[Again, feel free to decline if you aren't interested in this kind of change in this PR.]
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for consistent style.