Conversation
ralphbean
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking into something else, I noticed a couple of nits introduced by my previous PRs.
The doc addition in #384 renders with an undesired line break and incorrect indentation. This PR corrects the formatting in the documentation source to wrap the lines properly, so that the text will (hopefully) "flow" properly when rendered. It also does the same for a number of other long source lines (and, it adds a missing period and removes an extra space).
The change in #385 left
_update_on_close()with an unused parameter. This PR removes that parameter from the function signature and from each of the callers, and it removes the setup for it from the unit tests.