Fix update_skus bug when a single gen is set #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
lslebodn
reviewed
Nov 18, 2024
This commit fixes a bug on `update_skus` which happens whenever a plan has just a single generation set on SKU. In the previous versions it was looking only for the SKU ID suffix to determine the default and alternate gen, which was enough for all cases with 2 generations defined but would cause a bug (renaming the SKU ID) whenever a single generation was originally set. With this fix it looks not only in the SKU ID suffix but also on SKU image type to determine which generation is the default and which is the alternate to prevent renaming the default. Refers to SPSTRAT-462
JAVGan
added a commit
that referenced
this pull request
Nov 27, 2024
The PR #68 removed the loop iteration over all SKUs which were not required for detecting the default/alternate generations for `x64`, however such iteration is required to detect the `security_type`. This commit fixes it by creating a dedicated helper function `_get_security_type` for this purpose only.
JAVGan
added a commit
that referenced
this pull request
Nov 27, 2024
The PR #68 removed the loop iteration over all SKUs which were not required for detecting the default/alternate generations for `x64`, however such iteration is required to detect the `security_type`. This commit fixes it by creating a dedicated helper function `_get_security_type` for this purpose only.
JAVGan
added a commit
that referenced
this pull request
Dec 9, 2024
The PR #68 removed the loop iteration over all SKUs which were not required for detecting the default/alternate generations for `x64`, however such iteration is required to detect the `security_type`. This commit fixes it by creating a dedicated helper function `_get_security_type` for this purpose only.
JAVGan
added a commit
that referenced
this pull request
Dec 11, 2024
The PR #68 removed the loop iteration over all SKUs which were not required for detecting the default/alternate generations for `x64`, however such iteration is required to detect the `security_type`. This commit fixes it by creating a dedicated helper function `_get_security_type` for this purpose only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug on
update_skuswhich happens whenever a plan has just a single generation set on SKU.In the previous versions it was looking only for the SKU ID suffix to determine the default and alternate gen, which was enough for all cases with 2 generations defined but would cause a bug (renaming the SKU ID) whenever a single generation was originally set.
With this fix it looks not only in the SKU ID suffix but also on SKU image type to determine which generation is the default and which is the alternate to prevent renaming the default.
Refers to SPSTRAT-462