Key alias support [RHELDST-35396] #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
pre-commit issue will be fixed in #687 |
rajulkumar
approved these changes
Dec 9, 2025
For PQC signed RPMs (not only), Errata tool API will provide a string called
"key alias" on `sig_key` field in format "name1,name2,...". In order support
this following changes are now implemented:
For Errata source:
* replace `,` with `+` in string provided from `sig_key` field, this is
later provided to Koji source as a signing key argument.
For Koji source:
* keep backwards compatible behavior for parsing `signing_key` argument
* replace `+` with `,` for each value in `signing_key` (later used for
path to RPM file)
* extract signing key ID from RPM headers every time as we don't know
whether caller passed alias or actual key ID, as the alias can be
formed as one name only ("sig_key":"alias_name")
MichalHaluza
reviewed
Dec 9, 2025
for more information, see https://pre-commit.ci
MichalHaluza
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PQC signed RPMs (not only), Errata tool API will provide a string called
"key alias" on
sig_keyfield in format "name1,name2,...". In order supportthis following changes are now implemented:
For Errata source:
,with+in string provided fromsig_keyfield, this islater provided to Koji source as a signing key argument.
For Koji source:
signing_keyargument+with,for each value insigning_key(later used forpath to RPM file)
whether caller passed alias or actual key ID, as the alias can be
formed as one name only ("sig_key":"alias_name")