Add retry backoff max and jitter settings [RHELDST-32465]#35
Add retry backoff max and jitter settings [RHELDST-32465]#35crungehottman merged 1 commit intorelease-engineering:masterfrom
Conversation
|
@crungehottman, unclear who else to add for review. Are you the owner of this now? |
Yes, I am the owner now (despite having zero prior contributions to this project 🙃). To my knowledge, this repo is only used by exodus, so requesting review from me should suffice for now.
I think #36 might fix the codecov issue.
That's fine! I appreciate the attempt and explanation. 🙂 |
Previously these paramters used for urllib3's Retry were unset. Backoff max defaulted to 120, which was too low for Akamai's strict rate limiting. Jitter was also added to better spread requests, improve system stability.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 150 152 +2
=========================================
+ Hits 150 152 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@crungehottman, looks like your patch worked! |
Previously these paramters used for urllib3's Retry were unset. Backoff max defaulted to 120, which was too low for Akamai's strict rate limiting. Jitter was also added to better spread requests, improve system stability.