Skip to content

Adding MoonMiner#27

Merged
relic-se merged 3 commits intorelic-se:mainfrom
cogliano:main
Dec 29, 2025
Merged

Adding MoonMiner#27
relic-se merged 3 commits intorelic-se:mainfrom
cogliano:main

Conversation

@cogliano
Copy link
Contributor

I just released my Moon Miner game and added it here.

I'm not sure if I did this correctly, let me know if there are any problems. I was not able to do the "Update the database README" step on my system, not sure if it is required from reading the documentation.

Thanks.

Copy link
Owner

@relic-se relic-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could update the database readme by following these steps (https://github.com/relic-se/Fruit_Jam_Library/blob/main/database/CONTRIBUTING.md#4-update-the-database-readme), I think we'll be good to go!

I don't yet have a way to test the install process on real hardware until after the update, but I'll make sure to do so once we've got this in. Thank you for the submission!!

@relic-se
Copy link
Owner

I manually installed v1.0.2 (downloaded from the github source code on the release) of the game in /sd/apps/MoonMiner/ and it's failing on load for me. Here's the REPL output:

/sd/apps/MoonMiner/code.py output:
Moon Miner Game for Fruit Jam...
By Dan Cogliano - https://DanTheGeek.com
Failed to initialize DVI display: [Errno 2] No such file/directory: missions/._001/data.json
Failed to initialize display

From what I can tell, there are no hidden directories there, but a simple check in def load_mission_list(self): should fix this.

Also, some of the missions have folders titled "Corel Auto-Preserve", which I assume is some for of automatic backup. The images in these folders are adding a couple of MBs to the install size. That's not a problem for installing on SD, but it'll take up precious room on flash. I recommend adding that folder to .gitignore and removing them from your source code.

@relic-se
Copy link
Owner

Here's what I'm getting when I do scan the directory via REPL:

>>> os.listdir("/sd/apps/MoonMiner/missions")
['012', '._012', '001', '._001', '011', '._011', '002', '._002']

I'm using MacOS to copy the files over. I'm not sure if Finder automatically added those files or what. 🤷

@relic-se
Copy link
Owner

Yep, it's definitely a MacOS thing. This is what I'm reading from the file via REPL:

>>> with open("/sd/apps/MoonMiner/missions/._012", "rb") as f:
...     print(f.read())
b'\x00\x05\x16\x07\x00\x02\x00\x00Mac OS X        \x00\x02\x00\x00\x00...

I'm going to manually remove those files for now, but I'd still recommend adding in some error checking to help avoid this.

@cogliano
Copy link
Contributor Author

cogliano commented Dec 29, 2025

Yep, it's definitely a MacOS thing. This is what I'm reading from the file via REPL:

>>> with open("/sd/apps/MoonMiner/missions/._012", "rb") as f:
...     print(f.read())
b'\x00\x05\x16\x07\x00\x02\x00\x00Mac OS X        \x00\x02\x00\x00\x00...

I'm going to manually remove those files for now, but I'd still recommend adding in some error checking to help avoid this.

Thanks for the comments! Those Corel folders were hidden on my end, must be used by my image editing software. I also added exception checking for the file open code. New version is v1.0.3. Will work on the database readme next, but I get the error "no such option: -r" with the command "pip3 -r database/requirements.txt". I'm still a newbie in some areas :-)

My pip3 version is:

pip 25.3 from C:\Users\dan\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.13_qbz5n2kfra8p0\LocalCache\local-packages\Python313\site-packages\pip (python 3.13)

@relic-se
Copy link
Owner

but I get the error "no such option: -r" with the command "pip3 -r database/requirements.txt". I'm still a newbie in some areas :-)

This is an error on my end. I forgot to add the "install" action to the command. It should be pip3 install -r database/requirements.txt. 🤦 I've done a hotfix for this (#28) so the guide should be updated for future reference.

@relic-se
Copy link
Owner

After a testing the script, it errors out when trying to fetch the readme of your repository with a 404 (because it doesn't have one). I'm going to push an update to fix that error, but let's not worry about it here. It's more of a nice to have than a need to have. Thanks for fixing those bugs with the program! I'm excited to play it.

@relic-se relic-se merged commit 57c28b3 into relic-se:main Dec 29, 2025
1 check passed
@relic-se
Copy link
Owner

I can confirm that I was able to install and launch the game from the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants