Conversation
|
Thank you for the contribution, @cogliano ! Unfortunately, I think there is a slight issue that we'll need to work through before merging this PR. It should be possible to manually configure This will just need a bit of enhancement to check within directories to identify screensaver modules. I think I have an idea of how best to do this, so I'll take a crack at it soon. |
|
Thanks for the info. I thought it would be good to make a bundle of screensavers and have them all in one repository, since right now they are only a single file each. Also, when I add a new screensaver to the bundle in the future, I won't need to do a PR for the Fruit Jam Library. If this becomes problematic, let me know and I can split them out. |
|
No, I think this is a great approach, and I want to make sure bundling like this is supported. And yes you are right, you won't need to make any additional PRs for new releases/additions to an existing repository. Eventually, I plan to have proper support for versioning (#18), but at the moment, it'll just download the most recent. |
|
Thanks. BTW, I think this library is a great idea. I think we both saw the limitations/barriers of adding community projects to the main Fruit Jam OS project. I was thinking a library type add-on would be nice and then lo and behold you created one! I'm looking forward to the production release. Let me know if you need any testers. |
|
I've authored two PRs (see above) which enable your screensaver bundle to work. I've run through the entire procedure myself (download + selection via the screensavers app) for both screensavers, and they work great! I've got the star field one running for myself, tbh. 🤣 I'm going to go ahead and merge this PR, but it will require adafruit/Fruit-Jam-OS#91 to be merged before working 100% without manual configuration. |
Great minds think alike! The plan is for the development of this project will eventually lead to inclusion within Fruit Jam OS so that it will be packaged within the default installation.
There are a number of issues which I've identified but haven't yet put the legwork into (https://github.com/relic-se/Fruit_Jam_Library/issues). But the biggest issue facing the project right now and limiting its inclusion within Fruit Jam OS is the UI of browsing the database. I have a few ideas of how to improve the system, but any additional recommendations would be greatly appreciated! |
This pull request adds 2 new screensavers for the Fruit Jam OS, A maze generator and a star field display.