- 
                Notifications
    You must be signed in to change notification settings 
- Fork 326
(Micro PR) Created DatabaseInterface and simple implementations #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            AdamLenda
  wants to merge
  4
  commits into
  reliese:v1.x
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
JVZoo:move_schemas_method
  
      
      
   
  
    
  
  
  
 
  
      
    base: v1.x
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            4 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <?php | ||
|  | ||
| namespace Reliese\Meta; | ||
|  | ||
| use Illuminate\Database\MySqlConnection; | ||
| use Illuminate\Database\PostgresConnection; | ||
| use Illuminate\Database\SQLiteConnection; | ||
| use Reliese\Meta\MySql\Database as MySqlDatabase; | ||
| use Reliese\Meta\Postgres\Database as PostgresDatabase; | ||
| use Reliese\Meta\Sqlite\Database as SqliteDatabase; | ||
| use Reliese\Meta\MySql\Schema as MySqlSchema; | ||
| use Reliese\Meta\Postgres\Schema as PostgresSchema; | ||
| use Reliese\Meta\Sqlite\Schema as SqliteSchema; | ||
|  | ||
| use function get_class; | ||
|  | ||
| /** | ||
| * Class AdapterFactory | ||
| */ | ||
| class AdapterFactory | ||
| { | ||
| /** | ||
| * @param \Illuminate\Database\Connection $connection | ||
| * @return DatabaseInterface | ||
| */ | ||
| public function database($connection) | ||
| { | ||
| switch (get_class($connection)) { | ||
| case \Larapack\DoctrineSupport\Connections\MySqlConnection::class: | ||
| case MySqlConnection::class: | ||
| /** @noinspection PhpParamsInspection */ | ||
| return new MySqlDatabase($connection); | ||
| case SQLiteConnection::class: | ||
| /** @noinspection PhpParamsInspection */ | ||
| return new SqliteDatabase($connection); | ||
| case PostgresConnection::class: | ||
| /** @noinspection PhpParamsInspection */ | ||
| return new PostgresDatabase($connection); | ||
| } | ||
|  | ||
| throw new \RuntimeException(__METHOD__." does not define an implementation for ".DatabaseInterface::class); | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <?php | ||
|  | ||
| namespace Reliese\Meta; | ||
|  | ||
| use Reliese\Meta\MySql\Schema; | ||
|  | ||
| /** | ||
| * Interface DatabaseInterface | ||
| */ | ||
| interface DatabaseInterface | ||
| { | ||
| /** | ||
| * Returns an array of accessible schema names | ||
| * | ||
| * @return string[] | ||
| */ | ||
| public function getSchemaNames(); | ||
|  | ||
| /** | ||
| * @param string $schemaName | ||
| * @return Schema | ||
| */ | ||
| public function getSchema($schemaName); | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?php | ||
|  | ||
| namespace Reliese\Meta\MySql; | ||
|  | ||
| use Reliese\Meta\DatabaseInterface; | ||
|  | ||
| use function array_diff; | ||
|  | ||
| /** | ||
| * Class Database | ||
| */ | ||
| class Database implements DatabaseInterface | ||
| { | ||
| /** | ||
| * @var Schema[] | ||
| */ | ||
| private $schemaAdapters = []; | ||
|  | ||
| /** | ||
| * @var \Illuminate\Database\MySqlConnection | ||
| */ | ||
| private $connection; | ||
|  | ||
| /** | ||
| * Database constructor. | ||
| * @param \Illuminate\Database\MySqlConnection $connection | ||
| */ | ||
| public function __construct(\Illuminate\Database\MySqlConnection $connection) | ||
| { | ||
| $this->connection = $connection; | ||
| } | ||
|  | ||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function getSchemaNames() | ||
| { | ||
| $schemas = $this->connection->getDoctrineSchemaManager()->listDatabases(); | ||
|  | ||
| return array_diff($schemas, [ | ||
| 'information_schema', | ||
| 'sys', | ||
| 'mysql', | ||
| 'performance_schema', | ||
| ]); | ||
| } | ||
|  | ||
| /** | ||
| * @param string $schemaName | ||
| * @return Schema | ||
| */ | ||
| public function getSchema($schemaName) | ||
| { | ||
| if (!empty($this->schemaAdapters[$schemaName])) { | ||
| return $this->schemaAdapters[$schemaName]; | ||
| } | ||
| return $this->schemaAdapters[$schemaName] = new Schema($schemaName, $this->connection); | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <?php | ||
|  | ||
| namespace Reliese\Meta\Postgres; | ||
|  | ||
| use Reliese\Meta\DatabaseInterface; | ||
|  | ||
| use function array_diff; | ||
|  | ||
| /** | ||
| * Class Database | ||
| */ | ||
| class Database implements DatabaseInterface | ||
| { | ||
| /** | ||
| * @var Schema[] | ||
| */ | ||
| private $schemaAdapters = []; | ||
|  | ||
| /** | ||
| * @var \Illuminate\Database\PostgresConnection | ||
| */ | ||
| private $connection; | ||
|  | ||
| /** | ||
| * Database constructor. | ||
| * @param \Illuminate\Database\PostgresConnection $connection | ||
| */ | ||
| public function __construct(\Illuminate\Database\PostgresConnection $connection) | ||
| { | ||
| $this->connection = $connection; | ||
| } | ||
|  | ||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function getSchemaNames() | ||
| { | ||
| $schemas = $this->connection->getDoctrineSchemaManager()->listDatabases(); | ||
|  | ||
| return array_diff($schemas, [ | ||
| 'postgres', | ||
| 'template0', | ||
| 'template1', | ||
| ]); | ||
| } | ||
|  | ||
| /** | ||
| * @param string $schemaName | ||
| * @return Schema | ||
| */ | ||
| public function getSchema($schemaName) | ||
| { | ||
| if (!empty($this->schemaAdapters[$schemaName])) { | ||
| return $this->schemaAdapters[$schemaName]; | ||
| } | ||
| return $this->schemaAdapters[$schemaName] = new Schema($schemaName, $this->connection); | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <?php | ||
|  | ||
| namespace Reliese\Meta\Sqlite; | ||
|  | ||
| use Reliese\Meta\DatabaseInterface; | ||
|  | ||
| /** | ||
| * Class Database | ||
| */ | ||
| class Database implements DatabaseInterface | ||
| { | ||
| /** | ||
| * @var Schema[] | ||
| */ | ||
| private $schemaAdapters = []; | ||
|  | ||
| /** | ||
| * @var \Illuminate\Database\SQLiteConnection | ||
| */ | ||
| private $connection; | ||
|  | ||
| /** | ||
| * Database constructor. | ||
| * @param \Illuminate\Database\SQLiteConnection $connection | ||
| */ | ||
| public function __construct(\Illuminate\Database\SQLiteConnection $connection) | ||
| { | ||
| $this->connection = $connection; | ||
| } | ||
|  | ||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function getSchemaNames() | ||
| { | ||
| return ['database']; | ||
| } | ||
|  | ||
| /** | ||
| * @param string $schemaName | ||
| * @return Schema | ||
| */ | ||
| public function getSchema($schemaName) | ||
| { | ||
| if (!empty($this->schemaAdapters[$schemaName])) { | ||
| return $this->schemaAdapters[$schemaName]; | ||
| } | ||
| return $this->schemaAdapters[$schemaName] = new Schema($schemaName, $this->connection); | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method's cohesion is very low compared to the rest of the methods. It makes sense to put this logic elsewhere.