Skip to content

Fix constant names on casts and fillable #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

Fix constant names on casts and fillable #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Coders/Model/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ protected function parseColumn(Fluent $column)
// TODO: Check type cast is OK
$cast = $column->type;

$propertyName = $this->usesPropertyConstants() ? 'self::'.strtoupper($column->name) : $column->name;
$propertyName = $this->usesPropertyConstants() ? 'self::'.strtoupper(Str::snake($column->name)) : $column->name;

// Due to some casting problems when converting null to a Carbon instance,
// we are going to treat Soft Deletes field as string.
Expand Down