Skip to content

Conversation

@C-ArenA
Copy link
Contributor

@C-ArenA C-ArenA commented Aug 29, 2024

This PR fixes the schemas() method to stop using Doctrine. It treats "schemas" as "databases" instead of "PostgreSQL Schemas" as stated in a comment in the same file. It's not a big change, but it now works perfectly with PostgreSQL connections and partially addresses issues #286 and #292.

@finiteinfinity finiteinfinity merged commit 75111e5 into reliese:v1.x Sep 12, 2024
@Benjaminhu
Copy link

@C-ArenA @finiteinfinity I am currently actively using PostgreSQL. While investigating a bug the other day, I ran into an undocumented Laravel function: search_path: laravel/ideas#918 This feature was added in Laravel 9, so if you use more than one scheme, you must list them here. Care must be taken that the schema containing the migrations table is the first (usually public).

I think it would be worthwhile to adapt the operation to this, i.e. if data is provided there, it is used. What do you think?

@Benjaminhu
Copy link

@C-ArenA please take a look at my PR: #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants