-
-
Notifications
You must be signed in to change notification settings - Fork 922
Add tel: as href support #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 3
Lines 1354 1746 +392
Branches 113 124 +11
==========================================
+ Hits 1354 1746 +392 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: JounQin <[email protected]>
|
Tel is intentionally not supported #865, #829, and #655 (comment), but can be added through an option |
|
https://spec.commonmark.org/0.22/#scheme @ChristianMurphy It seems there are a lot of protocols supported in commonmark spec. Oh, sorry, the latest version is https://spec.commonmark.org/0.31.2/#scheme |
|
There are a lot that are parsed, but they are intentionally filtered out to make renders safe, for example GFM e.g. |
|
@ChristianMurphy Thanks for clarification, just found the related commit 08ead9e But it lacks explanation why it's removed and considered as unsafe, and why |
|
The default is what GH does (not particularly GFM, that’s only a part of everything that GH does). GH has a small allow list. That small list is safe. We follow GH in many cases. You can configure things: see the readme: pass a |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@wooorm Maybe it's worth to mention that we follow GitHub's behavior as default at https://github.com/remarkjs/react-markdown#security |
|
Thanks for the suggestion. I added a paragraph on the internal workings of |
Initial checklist
Description of changes
Add support tel as href: