Skip to content

Add onComplete callback for completing processing in MarkdownHooks #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add onComplete callback for completing processing in MarkdownHooks #913

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
caa1748
Add onComplete callback for completing processing in MarkdownHooks
BlackRam-oss May 6, 2025
6ade36e
Update the onComplete callback type to include the node and error
BlackRam-oss May 6, 2025
747c23a
Add onComplete to Markdown hook to handle processing completion
BlackRam-oss May 7, 2025
debec9e
Update the onComplete callback type to include file, tree, and error
BlackRam-oss May 7, 2025
e2c1dcf
Add test for `onComplete` support in MarkdownHooks
BlackRam-oss May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@
* Configuration specifically for {@linkcode MarkdownHooks}.
* @property {ReactNode | null | undefined} [fallback]
* Content to render while the processor processing the markdown (optional).
* @property {function(Root | undefined, Error | undefined): void | null | undefined} [onComplete]
* Callback when the processor is done processing.
*/

/**
Expand Down Expand Up @@ -232,6 +234,7 @@ export function MarkdownHooks(options) {
if (!cancelled) {
setError(error)
setTree(tree)
options.onComplete?.(tree, error)
}
})

Expand Down
Loading