Add @m2d/remark-docx to the plugins list#1431
Conversation
* 🟢 [`@m2d/remark-docx`](https://github.com/inokawa/remark-docx) — compile markdown to docx with support for GFM, tables, html, and more.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1431 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 142 138 -4
=========================================
- Hits 142 138 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for sharing @mayank1513! 🙇
|
|
Thank you for the feedback.
|
|
Publish a patch - moving docx to deps instead of peerDeps |
|
@mayank1513 |
https://github.com/GeoffreyBooth/dual-package-hazard?tab=readme-ov-file#dual-package-hazard |
Thanks, for now I think going with both CJS and ESM is good option. I do not find this very likely to happen. Besides, I have seen some companies still using some packages that are officially discontinued. So, I find it safer to allow both ESM and CJS as long as docx is supporting both. |
Signed-off-by: Mayank <mayank.srmu@gmail.com>
Done. Thank you! |
ESM only exports supports both CJS and ESM, in node 20+ https://nodejs.org/en/blog/release/v20.19.0#requireesm-is-now-enabled-by-default |
|
Agree, but not everyone is on or above node 20
Mayank Kumar Chaudhari
Software Architect (Focus Front End) | Microsoft Certified Expert
https://mayank-chaudhari.vercel.app/
…On Fri, Mar 28, 2025 at 5:24 PM Christian Murphy ***@***.***> wrote:
Thanks, for now I think going with both CJS and ESM is good option. I do
not find this very likely to happen. Besides, I have seen some companies
still using some packages that are officially discontinued. So, I find it
safer to allow both ESM and CJS as long as docx is supporting both.
ESM only exports supports both CJS and ESM, in node 20+
https://nodejs.org/en/blog/release/v20.19.0#requireesm-is-now-enabled-by-default
—
Reply to this email directly, view it on GitHub
<#1431 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCR4VPC6NTAQRNK7EBICH32WU2ANAVCNFSM6AAAAABZT7CXTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGE2TAMJRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: ChristianMurphy]*ChristianMurphy* left a comment
(remarkjs/remark#1431)
<#1431 (comment)>
Thanks, for now I think going with both CJS and ESM is good option. I do
not find this very likely to happen. Besides, I have seen some companies
still using some packages that are officially discontinued. So, I find it
safer to allow both ESM and CJS as long as docx is supporting both.
ESM only exports supports both CJS and ESM, in node 20+
https://nodejs.org/en/blog/release/v20.19.0#requireesm-is-now-enabled-by-default
—
Reply to this email directly, view it on GitHub
<#1431 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCR4VPC6NTAQRNK7EBICH32WU2ANAVCNFSM6AAAAABZT7CXTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGE2TAMJRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I personally think dual package is fine vs ESM only in near future. |
Node 18 is days away from being unsupported If you want to take time to support releases the Node foundation no longer support, you can 🤷 |
|
Thanks. Will rethink in a month or two. |
Initial checklist
Description of changes
@m2d/remark-docx— compile markdown to docx with support for GFM, tables, html, and more.