Handle has one and accepts nil value for it#301
Closed
pisaruk wants to merge 8 commits intoremi:masterfrom
Closed
Conversation
…ms' into handle_has_one_and_nil
|
This feature is useful, is there any problem in this implementation in particular? |
Contributor
|
most of the code here is PRd in #262 which i've responded to the OP about. going to close this for now and wait for a few small changes before we try to merge it. thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now has_one associations will be taken into account when calling to_params in the parent model.
That allow us to save a parent model containing has_one associations.
For example:
Besides that nil value will be accepted: