Fix get when used for has_one relationships with active model serializers#394
Open
siassaj wants to merge 2 commits intoremi:masterfrom
Open
Fix get when used for has_one relationships with active model serializers#394siassaj wants to merge 2 commits intoremi:masterfrom
siassaj wants to merge 2 commits intoremi:masterfrom
Conversation
…_model_serializer. When getting relations through has_one or has_many, we use Her::Model#get, not #get_resource which means that we can't assume that the resource is a collection. it may well be a single resource via has_one
Author
|
Anyone? |
Author
|
Beep boop |
Contributor
|
@siassaj Gem is not maintained anymore. |
Collaborator
|
hi @siassaj @giedriusr I've just got commit access on this repo and plan to get back on track with maintenance over time - will be in touch soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new_collection was called on even singular resources when format: :active_model_serializers was configured.
Example in specs