Skip to content
This repository was archived by the owner on Jun 13, 2019. It is now read-only.

Feature/console log level#44

Open
k-thorat wants to merge 6 commits intoremirobert:masterfrom
k-thorat:feature/console-log-level
Open

Feature/console log level#44
k-thorat wants to merge 6 commits intoremirobert:masterfrom
k-thorat:feature/console-log-level

Conversation

@k-thorat
Copy link
Contributor

@k-thorat k-thorat commented Oct 8, 2017

I have added feature to limit console logs based on log level.
Example If you set log level to warning, all the logs with warning & error will print on the console. This setting does not affect logs inside Dotzu manager.

Why?
Console is getting cluttered with logs. Choosing which log level you are interested will help on focusing critical issues.

Summary of changes:

  • Made LogLevel public and added none level
  • LogsSettings updated to set log level
  • Logger updated to use log level

Thanks a lot for your time.

Cheers!

@remirobert
Copy link
Owner

Thanks for the addition it's a great PR. Can you split that PR, in two, for the motion and the bubble?

@k-thorat
Copy link
Contributor Author

I am using Motion to show/launch Dotzu manager. So there is no functionality related to motion.
If you prefer I can change example to show Dotzu manager on click of table cell.

Also, as I commented on PR 43 This PR is built on top of 43 and contains changes for 43 as well. If this looks good, I will close PR 43.

Thank you for your time.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants