-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add deploy and verify contract #6394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsy822
wants to merge
42
commits into
master
Choose a base branch
from
add-contract-verification-checkbox
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+337
−45
Open
Changes from 39 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
b466ae3
feat: verify on deploy
2e6306d
fix context menu and model selection menu
7cc59ee
reverting provider
STetsing 5cac7aa
lint
STetsing 04ba18b
fix borders in menus
1ab13fc
fix test
7be76eb
lint
ea3b96a
add matomo keys
d753a8f
disable matomo necessary in settings
Aniket-Engg 03f53b0
disable cookies on settings disable
Aniket-Engg fd89f8b
remove matomo keys
a030af0
feat:apply portal-based submenus for Environment dropdown and reorder…
d01568e
feat: smart account dropdown ui
3e11d81
test(e2e): add end-to-end tests and minor refinements
8eb4b36
update provider test code
c9e757b
update switchEnvironment test
3e61f03
remove 'customize list' menu and update e2e tests
1e8b2ca
remove #pr and update e2e
37817d8
fix e2e test code
c4e1ad9
add verifiable chain list
a97b17a
dynamic conversation starters
c61dd05
lint
6a9f89e
update questions
ryestew 07a3278
minor
STetsing 0a3dad1
fixed e2e
STetsing 73b0d35
move repo
9694dae
fix matomo settings
Aniket-Engg cb610dd
remove lang selection
Aniket-Engg ea96642
RemixAI text
Aniket-Engg 2c034cf
remove locale e2e
Aniket-Engg faaf384
e2e test
74f3812
Merge branch 'master' into add-contract-verification-checkbox
hsy822 4dbdbbe
Merge branch 'master' into add-contract-verification-checkbox
hsy822 833e44f
feat(deployment): add receipt to verification plugin during contract …
07a64a9
Merge branch 'master' into add-contract-verification-checkbox
hsy822 f70f839
removed #pr
7c7e2b3
lint
6535bf8
set timeout for etherscan
838dca0
fix(settings): Sync global Etherscan API key to local plugin settings…
74d313e
feat: set default value for verification checkbox and hide it on unsu…
23843ca
Merge branch 'master' into add-contract-verification-checkbox
hsy822 7a5b8cc
update e2e test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
'use strict' | ||
import { NightwatchBrowser } from 'nightwatch' | ||
import init from '../helpers/init' | ||
|
||
declare global { | ||
interface Window { testplugin: { name: string, url: string }; } | ||
} | ||
|
||
module.exports = { | ||
'@disabled': true, | ||
before: function (browser: NightwatchBrowser, done: VoidFunction) { | ||
init(browser, done, null) | ||
}, | ||
|
||
'Should show warning for unsupported network when deploying with "Verify" on Remix VM #group1': function (browser: NightwatchBrowser) { | ||
browser | ||
.waitForElementVisible('*[data-id="remixIdeSidePanel"]') | ||
.clickLaunchIcon('filePanel') | ||
.click('*[data-id="treeViewLitreeViewItemcontracts"]') | ||
.openFile('contracts/1_Storage.sol') | ||
.clickLaunchIcon('udapp') | ||
.waitForElementVisible('*[data-id="Deploy - transact (not payable)"]') | ||
.waitForElementVisible('#deployAndRunVerifyContract') | ||
.click('#deployAndRunVerifyContract') | ||
.click('*[data-id="Deploy - transact (not payable)"]') | ||
.waitForElementVisible({ | ||
selector: "//*[contains(text(),'is not supported for verification via this plugin')]", | ||
locateStrategy: 'xpath', | ||
timeout: 10000 | ||
}) | ||
.end() | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have receipts for submittedContract and store it in local storage, such that it also shows up in the plugin's UI. See the
VerifyView
for reference.I also thought of refactoring the
VerifyView
once, since a lot of the logic from there could actually be reused for this feature.Anyway, very nice that you tackled this feature!