Skip to content

Render videos in md #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

Render videos in md #6414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b344bec
render videos in md
yann300 Sep 26, 2025
2a1b4de
fix aspect ratio for learnEth Video
Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion apps/learneth/src/pages/StepDetail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,40 @@ function StepDetailPage() {
)
}

const VideoRenderer = ({
node,
src,
alt,
...props
}: {
node?: any;
src?: string;
alt?: string;
[key: string]: any;
}) => {
if (alt === 'youtube') {
/*
<iframe width="560" height="315" src="https://www.youtube.com/embed/Eh1qgOurDxU?si=lz1JypmIJZ15OY4g" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>
*/
return (
<div className="position-relative overflow-hidden" style={{ paddingBottom: '56.25%', maxWidth: '100%', height: '0' }}>
<iframe
style={{ width: '100%', height: '100%', position: 'absolute', top: 0, left: 0 }}
src={src}
title="YouTube video player"
frameBorder="0"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
allowFullScreen
/>
</div>
);
}
if (alt === 'video') {
return <video controls src={src} style={{ maxWidth: '100%' }} />;
}
return <img src={src} alt={alt} {...props} />;
};

return (
<div className='pb-4'>
<div className="fixed-top">
Expand Down Expand Up @@ -104,7 +138,7 @@ function StepDetailPage() {
</>
)}
<div className="container-fluid">
<Markdown rehypePlugins={[rehypeRaw]}>{clonedStep.markdown?.content}</Markdown>
<Markdown components={{ img:VideoRenderer }} rehypePlugins={[rehypeRaw]}>{clonedStep.markdown?.content}</Markdown>
</div>
{clonedStep.test?.content ? (
<>
Expand Down