Skip to content

Commit 0a42723

Browse files
EloBtaion
authored andcommitted
Removed unnecessary className on Link (#3288)
1 parent 46d29e6 commit 0a42723

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

modules/Link.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ const Link = React.createClass({
6666
getDefaultProps() {
6767
return {
6868
onlyActiveOnIndex: false,
69-
className: '',
7069
style: {}
7170
}
7271
},
@@ -119,7 +118,7 @@ const Link = React.createClass({
119118
if (activeClassName || (activeStyle != null && !isEmptyObject(activeStyle))) {
120119
if (router.isActive(location, onlyActiveOnIndex)) {
121120
if (activeClassName)
122-
props.className += props.className === '' ? activeClassName : ` ${activeClassName}`
121+
props.className = `${props.className || ''} ${activeClassName}`.trim()
123122

124123
if (activeStyle)
125124
props.style = { ...props.style, ...activeStyle }

modules/__tests__/Link-test.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,15 @@ describe('A <Link>', function () {
2929
node = document.createElement('div')
3030
})
3131

32+
it('should not render unnecessary class=""', function () {
33+
render((
34+
<Link to="/something" />
35+
), node, function () {
36+
const a = node.querySelector('a')
37+
expect(a.hasAttribute('class')).toBe(false)
38+
})
39+
})
40+
3241
it('knows how to make its href', function () {
3342
class LinkWrapper extends Component {
3443
render() {

0 commit comments

Comments
 (0)