Skip to content

fix: decode Windows paths to prevent ENOENT in dev mode #14057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drewkovihair
Copy link

Fix: Decode Windows Paths in dev mode to prevent ENOENT

Summary

This fixes an error on Windows when running Hydrogen/React Router projects from folders that include spaces (e.g. D:\KOVI HAIR).

The Vite plugin currently passes encoded %20 paths into readFileSync, causing:

ENOENT: no such file or directory, open 'D:\KOVI%20HAIR\...'

Fix

We now decode routeFilePath before reading it:

const cleanPath = path.normalize(decodeURIComponent(routeFilePath));
const code = readFileSync(cleanPath, "utf-8");

Notes

  • Tested with Shopify Hydrogen dev setup and confirmed working
  • No impact on macOS or Linux environments
  • Fixes a long-standing issue for Windows users with space-containing directories

Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: eae93b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Major
@react-router/fs-routes Major
@react-router/remix-routes-option-adapter Major
create-react-router Major
react-router Major
react-router-dom Major
@react-router/architect Major
@react-router/cloudflare Major
@react-router/express Major
@react-router/node Major
@react-router/serve Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 23, 2025

Hi @drewkovihair,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 23, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@drewkovihair
Copy link
Author

Let me know if anything needs adjusting — happy to tweak as needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant