refactor: update @mjackson/* packages to @remix-run/*

[MichaelDeBoey]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 7507c5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[brophdawg11]

It looks like we have some CJS/ESM incompatibilities with the new packages?

[alexandrsashin]

Should update @remix-run/node-fetch-server. The latest version is 0.9.0.

[MichaelDeBoey]

@brophdawg11 It indeed seems like we have some CJS/ESM issues here, but can't really find out the actual problem 🤔

[alexandrsashin]

packages/react-router-node is being built as CommonJS, but we are importing ESM-only modules (@remix-run/node-fetch-server) using static imports. TypeScript (TS1479) throws an error, and tsup fails during DTS generation.

The solution is to migrate the packages/react-router-node package to ESM:
add "type": "module" to package.json, and update both the tsconfig and tsup configurations.

[alexandrsashin]

Minimal changes:
package.json

"type": "module",

tsconfig.json (I recommend to delete any comments from json)

{
  "include": ["**/*.ts"],
  "exclude": ["dist", "__tests__", "node_modules"],
  "compilerOptions": {
    "lib": ["DOM", "DOM.Iterable", "ES2022"],
    "target": "ES2022",
    "module": "ESNext",
    "moduleResolution": "Bundler",
    "allowSyntheticDefaultImports": true,
    "esModuleInterop": true,
    "strict": true,
    "jsx": "react",
    "declaration": true,
    "rootDir": ".",
    "outDir": "./dist",
    "noEmit": true,
    "resolveJsonModule": true,
    "allowImportingTsExtensions": true,
    "verbatimModuleSyntax": true,

    "skipLibCheck": true
  }
}

[MichaelDeBoey]

@alexandrsashin that would technically be a breaking change I guess, so I'll wait for @brophdawg11 and the rest of the team to decide what we want to do with this