-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
refactor(create-react-router): use native Fetch #14140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
c0b40c0
to
6a09814
Compare
6a09814
to
ccbe293
Compare
Tests are failing because we don't support env var proxy usage anymore with this change. Not sure if this is a use-case we want to support tbh 🤔 CC/ @markdalgleish is there any specific use-case you had in mind when implementing this? |
FYI, this was added way back in remix-run/remix#4159 |
And note this may be less of an issue now that Node natively supports proxies: https://nodejs.org/en/blog/release/v24.5.0#built-in-proxy-support-in-request-and-agent |
@timdorr We're still supporting Node v20 (even Node v18 for |
I know, I'm just saying there's a "fix" for users that might need support for proxies. Alternatively, we could import a version of unidici that supports proxies as well. |
Can we just do nothing? |
Since It comes at a cost of not supporting proxy users running |
I'm with @timdorr here and I think the benefits are greater than the drawbacks imo. |
Couldn't it be conditionally installed and used depending on node version? or it's something not really possible with node |
No, this is part of the |
yeah I don't know what the usage is for proxy users, but it sounds like it would be a breaking change so it's probably a non-starter. No one has ever complained about the execution time of |
As mentioned in remix-run/web-std-io#42 (comment), we probably don't need to use the
agent
option, so we can just use native Fetch API completelyI'm sure people from the wider @e18e ecosystem cleanup (like @43081j, @benmccann, @Fuzzyma, @outslept & @talentlessguy) will be very happy to see these kind of changes as well