Skip to content

Conversation

@y-nk
Copy link

@y-nk y-nk commented Aug 22, 2025

closes #14217

I think this way would work and non invasive. Types are provided by default so that they're not mandatory to pass, and default to UIMatch's defaults too. It only gives to users the way to enforce "maybe types" without force-casting with as.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

⚠️ No Changeset found

Latest commit: 9003cdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 22, 2025

Hi @y-nk,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 22, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 added the feature-request Used to close PRs that haven't gone through/been accepted the Proposal process yet label Aug 22, 2025
@brophdawg11
Copy link
Contributor

To align with our new Open Governance model, we are now asking that all new features go through the Proposal/RFC process and that we don't open PRs until a proposal has been been accepted and advanced to Stage 1.

If this feature doesn't have a Proposal, please open one so we can evaluate/discuss the proposed feature. You can link to this PR as an example of a potential implementation and we can re-open it if the proposal advances.

If this PR already has a Proposal but it has not yet been accepted, let's continue the discussion in the Proposal until it gets accepted and then we can look to open a PR. Feel free to link to this PR or to a branch in a forked repo to show what a potential implementation might look like.

If you have any questions, you can always reach out on Discord. Thanks again for providing feedback and helping us make React Router even better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed feature-request Used to close PRs that haven't gone through/been accepted the Proposal process yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useMatches missing generic

2 participants