You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the future.unstable_viteEnvironmentApi flag needed to be enabled when using the RSC Framework Mode plugin for the native Vite build process to be used. This PR updates our CLI to detect which React Router Vite plugin is being used, and if the RSC plugin is present, we use the new Vite Environment API build process regardless of future flags. This means that templates and tests can now be cleaned up since they don't require a react-router.config.ts to be present.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
We just published version 7.9.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!
We just published version 7.9.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdalgleish
deleted the
markdalgleish/rsc-framework-without-env-api-flag
branch
Previously the
future.unstable_viteEnvironmentApiflag needed to be enabled when using the RSC Framework Mode plugin for the native Vite build process to be used. This PR updates our CLI to detect which React Router Vite plugin is being used, and if the RSC plugin is present, we use the new Vite Environment API build process regardless of future flags. This means that templates and tests can now be cleaned up since they don't require areact-router.config.tsto be present.