-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
prerenderConcurrency
option
#14380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kirillgroshkov
wants to merge
8
commits into
remix-run:dev
Choose a base branch
from
kirillgroshkov:prerender-concurrency
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+664
−105
Open
prerenderConcurrency
option
#14380
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8391282
prerenderConcurrency
kirillgroshkov fbf9d15
review comments
kirillgroshkov 61c561f
eslint-disable
kirillgroshkov 451dcc3
eslint
kirillgroshkov 72e6e3c
Update
brophdawg11 e5e7e2f
Apply suggestion from @brophdawg11
brophdawg11 6129054
Fix lint error
brophdawg11 afe1c26
Fix config validation
brophdawg11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -210,6 +210,7 @@ | |
- kigawas | ||
- kilavvy | ||
- kiliman | ||
- kirillgroshkov | ||
- kkirsche | ||
- kno-raziel | ||
- knownasilya | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,155 @@ | ||
type BaseOptions = { | ||
/** | ||
Number of concurrently pending promises returned by `mapper`. | ||
|
||
Must be an integer from 1 and up or `Infinity`. | ||
|
||
@default Infinity | ||
*/ | ||
readonly concurrency?: number; | ||
}; | ||
|
||
export type Options = BaseOptions & { | ||
/** | ||
When `true`, the first mapper rejection will be rejected back to the consumer. | ||
|
||
When `false`, instead of stopping when a promise rejects, it will wait for all the promises to settle and then reject with an [`AggregateError`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError) containing all the errors from the rejected promises. | ||
|
||
Caveat: When `true`, any already-started async mappers will continue to run until they resolve or reject. In the case of infinite concurrency with sync iterables, *all* mappers are invoked on startup and will continue after the first rejection. [Issue #51](https://github.com/sindresorhus/p-map/issues/51) can be implemented for abort control. | ||
|
||
@default true | ||
*/ | ||
readonly stopOnError?: boolean; | ||
|
||
/** | ||
You can abort the promises using [`AbortController`](https://developer.mozilla.org/en-US/docs/Web/API/AbortController). | ||
|
||
@example | ||
``` | ||
import pMap from 'p-map'; | ||
import delay from 'delay'; | ||
|
||
const abortController = new AbortController(); | ||
|
||
setTimeout(() => { | ||
abortController.abort(); | ||
}, 500); | ||
|
||
const mapper = async value => value; | ||
|
||
await pMap([delay(1000), delay(1000)], mapper, {signal: abortController.signal}); | ||
// Throws AbortError (DOMException) after 500 ms. | ||
``` | ||
*/ | ||
readonly signal?: AbortSignal; | ||
}; | ||
|
||
export type IterableOptions = BaseOptions & { | ||
/** | ||
Maximum number of promises returned by `mapper` that have resolved but not yet collected by the consumer of the async iterable. Calls to `mapper` will be limited so that there is never too much backpressure. | ||
|
||
Useful whenever you are consuming the iterable slower than what the mapper function can produce concurrently. For example, to avoid making an overwhelming number of HTTP requests if you are saving each of the results to a database. | ||
|
||
Default: `options.concurrency` | ||
*/ | ||
readonly backpressure?: number; | ||
}; | ||
|
||
type MaybePromise<T> = T | Promise<T>; | ||
|
||
/** | ||
Function which is called for every item in `input`. Expected to return a `Promise` or value. | ||
|
||
@param element - Iterated element. | ||
@param index - Index of the element in the source array. | ||
*/ | ||
export type Mapper<Element = any, NewElement = unknown> = ( | ||
element: Element, | ||
index: number | ||
) => MaybePromise<NewElement | typeof pMapSkip>; | ||
|
||
/** | ||
@param input - Synchronous or asynchronous iterable that is iterated over concurrently, calling the `mapper` function for each element. Each iterated item is `await`'d before the `mapper` is invoked so the iterable may return a `Promise` that resolves to an item. Asynchronous iterables (different from synchronous iterables that return `Promise` that resolves to an item) can be used when the next item may not be ready without waiting for an asynchronous process to complete and/or the end of the iterable may be reached after the asynchronous process completes. For example, reading from a remote queue when the queue has reached empty, or reading lines from a stream. | ||
@param mapper - Function which is called for every item in `input`. Expected to return a `Promise` or value. | ||
@returns A `Promise` that is fulfilled when all promises in `input` and ones returned from `mapper` are fulfilled, or rejects if any of the promises reject. The fulfilled value is an `Array` of the fulfilled values returned from `mapper` in `input` order. | ||
|
||
@example | ||
``` | ||
import pMap from 'p-map'; | ||
import got from 'got'; | ||
|
||
const sites = [ | ||
getWebsiteFromUsername('sindresorhus'), //=> Promise | ||
'https://avajs.dev', | ||
'https://github.com' | ||
]; | ||
|
||
const mapper = async site => { | ||
const {requestUrl} = await got.head(site); | ||
return requestUrl; | ||
}; | ||
|
||
const result = await pMap(sites, mapper, {concurrency: 2}); | ||
|
||
console.log(result); | ||
//=> ['https://sindresorhus.com/', 'https://avajs.dev/', 'https://github.com/'] | ||
``` | ||
*/ | ||
export function pMap<Element, NewElement>( | ||
input: AsyncIterable<Element | Promise<Element>> | Iterable<Element | Promise<Element>>, | ||
mapper: Mapper<Element, NewElement>, | ||
options?: Options | ||
): Promise<Array<Exclude<NewElement, typeof pMapSkip>>>; | ||
|
||
/** | ||
@param input - Synchronous or asynchronous iterable that is iterated over concurrently, calling the `mapper` function for each element. Each iterated item is `await`'d before the `mapper` is invoked so the iterable may return a `Promise` that resolves to an item. Asynchronous iterables (different from synchronous iterables that return `Promise` that resolves to an item) can be used when the next item may not be ready without waiting for an asynchronous process to complete and/or the end of the iterable may be reached after the asynchronous process completes. For example, reading from a remote queue when the queue has reached empty, or reading lines from a stream. | ||
@param mapper - Function which is called for every item in `input`. Expected to return a `Promise` or value. | ||
@returns An async iterable that streams each return value from `mapper` in order. | ||
|
||
@example | ||
``` | ||
import {pMapIterable} from 'p-map'; | ||
|
||
// Multiple posts are fetched concurrently, with limited concurrency and backpressure | ||
for await (const post of pMapIterable(postIds, getPostMetadata, {concurrency: 8})) { | ||
console.log(post); | ||
}; | ||
``` | ||
*/ | ||
export function pMapIterable<Element, NewElement>( | ||
input: AsyncIterable<Element | Promise<Element>> | Iterable<Element | Promise<Element>>, | ||
mapper: Mapper<Element, NewElement>, | ||
options?: IterableOptions | ||
): AsyncIterable<Exclude<NewElement, typeof pMapSkip>>; | ||
|
||
/** | ||
Return this value from a `mapper` function to skip including the value in the returned array. | ||
|
||
@example | ||
``` | ||
import pMap, {pMapSkip} from 'p-map'; | ||
import got from 'got'; | ||
|
||
const sites = [ | ||
getWebsiteFromUsername('sindresorhus'), //=> Promise | ||
'https://avajs.dev', | ||
'https://example.invalid', | ||
'https://github.com' | ||
]; | ||
|
||
const mapper = async site => { | ||
try { | ||
const {requestUrl} = await got.head(site); | ||
return requestUrl; | ||
} catch { | ||
return pMapSkip; | ||
} | ||
}; | ||
|
||
const result = await pMap(sites, mapper, {concurrency: 2}); | ||
|
||
console.log(result); | ||
//=> ['https://sindresorhus.com/', 'https://avajs.dev/', 'https://github.com/'] | ||
``` | ||
*/ | ||
export const pMapSkip: unique symbol; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.