fix: fetcher.submit failing with plain objects containing tagName pro… #14534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14526
Summary
Updates
isHtmlElement()to useinstanceof HTMLElementinstead of checking for the presence of atagNamestring property. This prevents plain data objects with atagNameproperty from being incorrectly identified as HTML elements.The previous implementation would throw an error when submitting objects like
{ tagName: "div", data: "test" }viafetcher.submit(), as they were mistakenly treated as invalid HTML elements.Changes
Updated
isHtmlElement()inpackages/react-router/lib/dom/dom.tsto useinstanceof HTMLElementI largely followed the approach described in rossipedia’s comment, and additionally only introduced the following tests and edge-case handling,
Test
packages/react-router/__tests__/dom/fetcher-submit-tagname-test.tsx