Skip to content

Conversation

@dogxii
Copy link
Contributor

@dogxii dogxii commented Dec 8, 2025

  • Fix authMiddleware: remove invalid arrow function syntax from function declaration
  • Fix clientMiddleware: remove reference to undefined response variable

Copilot AI review requested due to automatic review settings December 8, 2025 09:07
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: e0b4610

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 8, 2025

Hi @dogxii,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two syntax and logic errors in code examples within the route-module documentation, ensuring the examples are valid and executable.

  • Fixed invalid arrow function syntax in authMiddleware function declaration
  • Removed reference to undefined response variable in clientMiddleware logging example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 8, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Dec 8, 2025

Thanks!

@timdorr timdorr merged commit 8da8fdf into remix-run:main Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants