fix(dev): use SPA fallback as index.html when public/index.html exists - #15453
Open
Cypher-Aura-19 wants to merge 1 commit into
Open
fix(dev): use SPA fallback as index.html when public/index.html exists#15453Cypher-Aura-19 wants to merge 1 commit into
Cypher-Aura-19 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In SPA mode (
ssr: falsewithout prerendering/), always promote the generated SPA fallback toindex.html, even when Vite has already copied apublic/index.htmlinto the client build directory.Why?
Since the v8 Environment API migration, the SPA shell is first generated as
__spa-fallback.htmland later renamed toindex.html.When an application contains
public/index.html, Vite copies that file into the output directory first. The existing finalize logic sees thatindex.htmlalready exists and skips the rename, leaving the actual generated SPA shell in__spa-fallback.html.Static hosts then serve the copied
public/index.htmlinstead of the React Router SPA shell.This restores the previous SPA behavior while preserving the existing behavior when
/itself is prerendered.Testing
ssr: falsewithpublic/index.htmlindex.htmlcontains the complete SPA document and hydrates correctlyvite-spa-mode: 46/46 passedvite-prerender: 37/37 passedvite-build: 16/16 passed@react-router/devtypecheck passedFixes #15444