Open
Conversation
This was referenced Aug 25, 2025
Contributor
Author
Contributor
Author
|
im going to temporarily not fail the dejagnu tests as not able to run dejagnu on osx. (fails when running fish) |
Owner
|
Hi @maxandersen thank you for helping push this forward. I see this one test that now seems to be failing for some reason: Does this need to be added to {
"name" : "picocli.AutoComplete$GenerateCompletion$Shell",
"allDeclaredConstructors" : true,
"allPublicConstructors" : true,
"allDeclaredMethods" : true,
"allPublicMethods" : true
}, |
Contributor
Author
|
sounds about right. pushed. |
Contributor
Author
|
the failure on java 9 is that it does not seem available on github actions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


rebased #1925 as I realized fish now works with jbang scripts so I got a good reason to make this work :)
I've added basic support to the GenerateCompletion command for choosing which variant to generate bash/zsh or fish.
But I didn't grok what the meaning is for the AutoComplete which generates code does does not run without user modification so i did not add/change that.
I've tested it in jbang at jbangdev/jbang#2195 and would love to see a picocli release with this included so I can release jbang with fish completion :)