Open
Conversation
added 2 commits
February 19, 2026 15:33
Updated build files to sync with code (desync since remotestorage@8a69627)
Without this fix, the equal function could potentially throw a TypeError due to the variable holding a value of null.
darkdread
force-pushed
the
bugfix/equal-null-object
branch
from
22d7dc3 to
206ca97
Compare
raucao
requested changes
Feb 19, 2026
Member
raucao
left a comment
raucao
left a comment
There was a problem hiding this comment.
LGTM. 👍 And many thanks for porting one of the remaining test suites in the process!
Could you perhaps remove the release directory changes from the branch/PR so that they get built only by the release/version script?
It could also be useful to add a short description of how you actually encountered this bug, so we can document the fix properly in the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix equality checking for null type