@remotion/player: Don't create an AudioContext if mounting a <Thumbnail>
#6249
+30
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the <Thumbnail> component by preventing unnecessary AudioContext creation, since thumbnails are static frames and don't require audio functionality.
Key Changes:
- Added
audioEnabledboolean parameter throughout the audio context hierarchy - Set
audioEnabled={false}for Thumbnail components to skip AudioContext creation - Refactored
useSingletonAudioContextto use object parameters for better clarity - Simplified player-example to focus on Thumbnail demonstration
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/player/src/Thumbnail.tsx |
Passes audioEnabled={false} to prevent audio context creation in thumbnails |
packages/player/src/SharedPlayerContext.tsx |
Adds audioEnabled prop to interface and threads it through to SharedAudioContextProvider |
packages/player/src/Player.tsx |
Passes audioEnabled (implicitly true) to maintain audio functionality in Player |
packages/player-example/pages/index.tsx |
Simplifies example by removing Player and other components, focusing only on Thumbnail demonstration |
packages/core/src/audio/use-audio-context.ts |
Refactors to object parameters and adds early return when audioEnabled is false |
packages/core/src/audio/shared-audio-tags.tsx |
Adds audioEnabled prop and passes it to useSingletonAudioContext |
packages/core/src/RemotionRoot.tsx |
Changes audioEnabled/videoEnabled types from boolean | null to boolean and passes audioEnabled to SharedAudioContextProvider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.