Skip to content

Conversation

@JonnyBurger
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 7, 2026 09:37
@vercel
Copy link
Contributor

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
bugs Ready Ready Preview, Comment Jan 7, 2026 4:09pm
remotion Ready Ready Preview, Comment Jan 7, 2026 4:09pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR redesigns the remotion.dev/experts page by moving the experts page logic and data from the docs package to the promo-pages package, enabling better code reuse and a modernized design with Tailwind CSS.

Key Changes

  • Extracted experts data and page components into the @remotion/promo-pages package for reusability
  • Redesigned the experts page UI using Tailwind CSS instead of CSS modules
  • Updated disclaimer text for consistency across the application

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
packages/promo-pages/src/index.css Added CSS styles for the experts page with responsive breakpoints
packages/promo-pages/src/components/homepage/layout/Button.tsx Added optional fullWidth prop to the Button component
packages/promo-pages/src/components/experts/experts-icons.tsx Created new icon components (Twitter, LinkedIn, GitHub, Email, VideoCall, PersonalWebsite)
packages/promo-pages/src/components/experts/experts-data.tsx Migrated expert profiles data with type definitions
packages/promo-pages/src/components/experts/ExpertsPage.tsx Implemented new experts listing page component with card-based layout
packages/promo-pages/src/components/experts.tsx Created export file for experts-related components
packages/promo-pages/bundle.ts Added experts.tsx to the build entry points
packages/docs/src/pages/experts/index.tsx Refactored to use the new ExpertsPageContent component from promo-pages
packages/docs/src/pages/experts/experts.module.css Removed old CSS module file (no longer needed)
packages/docs/src/components/ExpertPage.tsx Updated disclaimer text and added minWidth to description styling

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JonnyBurger and others added 2 commits January 7, 2026 11:05
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JonnyBurger and others added 2 commits January 7, 2026 12:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@JonnyBurger
Copy link
Member Author

@claude Fix the formatting errors in last failed CI

@claude
Copy link

claude bot commented Jan 7, 2026

Claude finished @JonnyBurger's task in 4m 20s —— View job


Fixed CI formatting errors ✓

  • Identify formatting issue
  • Fix import ordering in ExpertPage.tsx
  • Commit and push changes

Summary

Found and fixed the formatting issue that was causing CI to fail. The problem was in packages/docs/src/components/ExpertPage.tsx where imports were not in alphabetical order as required by the prettier-plugin-organize-imports plugin.

Changes made:

  • Reorganized imports in ExpertPage.tsx to be alphabetically sorted
  • Moved useDocusaurusContext import to its correct position (after Head, before useLocation)
  • Removed the extra blank line between import groups

Commit: 59fd729

The CI should now pass the formatting check when it runs.

--- | Branch: redesigned-experts

Co-authored-by: Jonny Burger <JonnyBurger@users.noreply.github.com>
@JonnyBurger
Copy link
Member Author

@claude more lint errors in ExpertPage.tsx, fix them

@claude
Copy link

claude bot commented Jan 7, 2026

Claude finished @JonnyBurger's task in 1m 47s —— View job


Fixed lint errors in ExpertPage.tsx ✓

  • Read ExpertPage.tsx to identify lint errors
  • Fix Prettier formatting issues (added missing alt attribute)
  • Commit and push changes

Summary

Fixed the formatting error in ExpertPage.tsx by adding a missing alt attribute to the expert profile image on line 130.

Changes made:

  • Added alt={expert.name} to the <img> tag for accessibility compliance
  • This resolves the Prettier formatting check that was failing in CI

Commit: be0bfe3

The CI formatting check should now pass.

--- | Branch: redesigned-experts

Co-authored-by: Jonny Burger <JonnyBurger@users.noreply.github.com>
@JonnyBurger JonnyBurger merged commit 9f311d4 into main Jan 7, 2026
11 of 14 checks passed
@JonnyBurger JonnyBurger deleted the redesigned-experts branch January 7, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants