-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Redesigned remotion.dev/experts #6258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR redesigns the remotion.dev/experts page by moving the experts page logic and data from the docs package to the promo-pages package, enabling better code reuse and a modernized design with Tailwind CSS.
Key Changes
- Extracted experts data and page components into the
@remotion/promo-pagespackage for reusability - Redesigned the experts page UI using Tailwind CSS instead of CSS modules
- Updated disclaimer text for consistency across the application
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/promo-pages/src/index.css | Added CSS styles for the experts page with responsive breakpoints |
| packages/promo-pages/src/components/homepage/layout/Button.tsx | Added optional fullWidth prop to the Button component |
| packages/promo-pages/src/components/experts/experts-icons.tsx | Created new icon components (Twitter, LinkedIn, GitHub, Email, VideoCall, PersonalWebsite) |
| packages/promo-pages/src/components/experts/experts-data.tsx | Migrated expert profiles data with type definitions |
| packages/promo-pages/src/components/experts/ExpertsPage.tsx | Implemented new experts listing page component with card-based layout |
| packages/promo-pages/src/components/experts.tsx | Created export file for experts-related components |
| packages/promo-pages/bundle.ts | Added experts.tsx to the build entry points |
| packages/docs/src/pages/experts/index.tsx | Refactored to use the new ExpertsPageContent component from promo-pages |
| packages/docs/src/pages/experts/experts.module.css | Removed old CSS module file (no longer needed) |
| packages/docs/src/components/ExpertPage.tsx | Updated disclaimer text and added minWidth to description styling |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@claude Fix the formatting errors in last failed CI |
|
Claude finished @JonnyBurger's task in 4m 20s —— View job Fixed CI formatting errors ✓
SummaryFound and fixed the formatting issue that was causing CI to fail. The problem was in Changes made:
Commit: 59fd729 The CI should now pass the formatting check when it runs. |
Co-authored-by: Jonny Burger <JonnyBurger@users.noreply.github.com>
|
@claude more lint errors in ExpertPage.tsx, fix them |
|
Claude finished @JonnyBurger's task in 1m 47s —— View job Fixed lint errors in ExpertPage.tsx ✓
SummaryFixed the formatting error in Changes made:
Commit: be0bfe3 The CI formatting check should now pass. |
Co-authored-by: Jonny Burger <JonnyBurger@users.noreply.github.com>
No description provided.