@remotion/media: Make media tags wrap in an invisible <Sequence> and allow from and durationInFrames props#6983
Conversation
… inner Sequence Made-with: Cursor
|
Reviewed PR #6983. The main feedback is that the unconditional Task list (5/5 completed)
|
… Audio Made-with: Cursor
There was a problem hiding this comment.
The <Sequence> wrapper is unconditional — it is always rendered even when the user does not pass from or durationInFrames. While frame computation, layout, and content gating are all unaffected (the defaults from=0, durationInFrames=Infinity, layout="none" are functionally transparent), the wrapper introduces a non-null SequenceContext where there was previously null. This changes the render asset ID strings generated by AudioForRendering and VideoForRendering.
Big Pickle (free) | 𝕏
|
Reviewed PR #6983 — no actionable issues found. The Task list (4/4 completed)
|
@remotion/media: Add optional from and durationInFrames with hidden inner Sequence@remotion/media: Make media tags wrap in an invisible <Sequence> and allow from and durationInFrames props
There was a problem hiding this comment.
Clean implementation. The unconditional <Sequence layout="none" from={0} durationInFrames={Infinity} showInTimeline={false}> wrapper is a behavioral no-op for the default case — useCurrentFrame(), useVideoConfig(), visibility gating, and DOM output are all unchanged when no from/durationInFrames is provided. The SequenceContext transitions from null to non-null, but all downstream branches (including the id generation in AudioForRendering/VideoForRendering and nested-Sequence offset calculations) produce functionally equivalent results for these default values. Docs version 4.0.445 is correct against current 4.0.444.
Big Pickle (free) | 𝕏

Summary
Adds optional
fromanddurationInFramesto<Video>and<Audio>in@remotion/media, implemented by wrapping content in an inner<Sequence layout="none" …>withshowInTimeline={false}so timing matches<Sequence>semantics without an extra visible timeline row for that wrapper.Testing
bunx turbo run make --filter='@remotion/media'Documentation
Tradeoffs
<Video>in an outer<Sequence>; timing composes as with nested sequences.showInTimeline={false}; the media row remains the primary visible clip.Issues
(none linked)