Skip to content

Skills: clarify defaultOutName must omit file extension#6984

Closed
JonnyBurger wants to merge 1 commit intomainfrom
docs/skill-defaultOutName-no-extension
Closed

Skills: clarify defaultOutName must omit file extension#6984
JonnyBurger wants to merge 1 commit intomainfrom
docs/skill-defaultOutName-no-extension

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Summary

The agent skill for calculateMetadata showed defaultOutName without an extension in the code sample, but the prose and return-value list did not explain that the renderer appends the codec extension (see getDefaultOutLocation in @remotion/studio-shared). Including .mp4 or .mov in defaultOutName produces paths like Caption-First.mov.mov.

Changes

  • Document that the file extension must be omitted and why.
  • Clarify the defaultOutName bullet in the return value section.

Made with Cursor

Remotion appends the codec extension in getDefaultOutLocation; documenting
this avoids duplicated suffixes like video.mp4.mp4.

Made-with: Cursor
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Apr 4, 2026 10:44am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
remotion Skipped Skipped Apr 4, 2026 10:44am

Request Review

@vercel vercel bot temporarily deployed to Preview – remotion April 4, 2026 10:44 Inactive
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Apr 4, 2026

Reviewed PR #6984 — no actionable issues. The documentation changes accurately reflect the behavior of getDefaultOutLocation in @remotion/studio-shared, which unconditionally appends the codec extension to defaultOutName. Approved.

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Big Pickle (free) | 𝕏

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against getDefaultOutLocation in packages/studio-shared/src/get-default-out-name.ts — the extension is unconditionally appended to compositionDefaultOutName (line 31), so including one in defaultOutName does indeed produce double extensions. Changes are accurate and concise.

Pullfrog  | View workflow run | Using Big Pickle (free) | 𝕏

@JonnyBurger JonnyBurger changed the title docs(skills): clarify defaultOutName must omit file extension Skills: clarify defaultOutName must omit file extension Apr 4, 2026
@JonnyBurger
Copy link
Copy Markdown
Member Author

Closing: upstream skill example already omitted the extension; the drift was in the vendored copy in the consuming repo, not a gap in remotion-dev/skills.

@JonnyBurger JonnyBurger closed this Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant