build: add cmake to fix pyopenjtalk dependency and sync CI deps with Docker #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Docker Ensure that `cmake` is installed in both CPU and GPU Docker images, as well as in the GitHub Actions CI environment. Cmake is required to build `pyopenjtalk` because `kokoro-fastapi` depends on `misaki[ja]` which depends on `pyopenjtalk`. Additionally, sync CI dependency list. Changes made: - Added `cmake` to the apt-get install commands in: - `.github/workflows/ci.yml` - `docker/cpu/Dockerfile` - `docker/gpu/Dockerfile` - Synchronize GitHub Actions CI workflow dependencies with Dockerfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
cmakeis installed in both CPU and GPU Docker images, as well as in the GitHub Actions CI environment. Cmake is required to buildpyopenjtalkbecausekokoro-fastapidepends onmisaki[ja]which depends onpyopenjtalk. Additionally, sync CI dependency list.Changes made:
cmaketo the apt-get install commands in:.github/workflows/ci.ymldocker/cpu/Dockerfiledocker/gpu/Dockerfile