Add AMD GPU support #432
Merged
Add AMD GPU support #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @kprinssu this looks great Is it possible to pin the Rocblas/MiOpen, and remove or set a debug profile on the seccomp:unconfined + SYS_PTRACE? And adjust the target image location to this repo I don't have the hardware to test, but glad to merge it |
Contributor
Author
|
The MIOpen libraries are provided by AMD and are already pinned via en environment variable in the Dockerfile. The ROCBlas binaries are maintained by the Arch team. I'll look into pinning these shortly. In regards to maintaining and testing AMD support, I have some Vega 20 and Navi 4 cards on hand. I'll be happy to maintain them going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ROCm and will support most AMD GPUs. I am targetting ROCm 6.4 as it has decent support for RDNA 4 (gfx120x) to Vega 20 (gfx906).
This PR should be considered experimental and I am happy to provide long term support AMD cards.