Merged
Conversation
Until now, only the probabilities of alternation alternatives could be defined externally through a JSON file. With this change, the scope of model weight control is broadened to include quantifiers as well. The JSON lookup is now split into two sections: `alts` for alternation alternatives and `quants` for quantifiers. The file is still provided through the existing `--weights` command-line option. This commit also updates the C++ implementation with this new feature, along with adding the missing CLI support and parsing logic to match the Python version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, only the probabilities of alternation alternatives could be defined externally through a JSON file. With this change, the scope of model weight control is broadened to include quantifiers as well. The JSON lookup is now split into two sections:
altsfor alternation alternatives andquantsfor quantifiers. The file is still provided through the existing--weightscommand-line option.This commit also updates the C++ implementation with this new feature, along with adding the missing CLI support and parsing logic to match the Python version.