Skip to content

[Snyk] Security upgrade eslint from 7.32.0 to 9.26.0#460

Open
rennokki wants to merge 1 commit intomasterfrom
snyk-fix-d4f9c66c63c8078aa7e6bc84894db64e
Open

[Snyk] Security upgrade eslint from 7.32.0 to 9.26.0#460
rennokki wants to merge 1 commit intomasterfrom
snyk-fix-d4f9c66c63c8078aa7e6bc84894db64e

Conversation

@rennokki
Copy link
Member

@rennokki rennokki commented Feb 1, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Uncontrolled Recursion
SNYK-JS-ESLINT-15102420
  505  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Copilot AI review requested due to automatic review settings February 1, 2026 11:55
@gemini-code-assist
Copy link

Summary of Changes

Hello @rennokki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, addresses a critical security vulnerability within the eslint dependency. It upgrades eslint to a newer version to mitigate an 'Uncontrolled Recursion' issue, ensuring the project's security posture is maintained by incorporating the latest security patches.

Highlights

  • Security Upgrade: Upgraded the eslint dependency from version 7.5.0 to 9.26.0 to address identified security vulnerabilities.
  • Vulnerability Fixed: This update specifically resolves an 'Uncontrolled Recursion' vulnerability (SNYK-JS-ESLINT-15102420) which had a score of 505.
  • Automated Remediation: This pull request was automatically generated by Snyk to apply the necessary security fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, upgrades eslint from version 7 to 9 to fix a security vulnerability. While this is a necessary update, it is incomplete and will cause your CI/CD pipeline to fail. The upgrade to ESLint v9 is a major version bump with breaking changes, and it requires corresponding major version upgrades for @typescript-eslint/parser and @typescript-eslint/eslint-plugin. I've left a critical comment detailing the required additional dependency updates to ensure your linting setup continues to work correctly.

"@typescript-eslint/eslint-plugin": "^4.33.0",
"@typescript-eslint/parser": "^4.31.1",
"eslint": "^7.5.0",
"eslint": "^9.26.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading eslint to a new major version (v9) introduces breaking changes. The current versions of @typescript-eslint/parser (^4.31.1 on line 41) and @typescript-eslint/eslint-plugin (^4.33.0 on line 40) are not compatible with ESLint v9. This will cause the lint script to fail.

To resolve this, you must also upgrade these packages to a version compatible with ESLint v9. As of now, this requires using v8.x of the @typescript-eslint packages, which are currently in an alpha state.

You will need to update your dependencies to use these alpha versions, for example:

    "@typescript-eslint/eslint-plugin": "^8.0.0-alpha.35",
    "@typescript-eslint/parser": "^8.0.0-alpha.35",

Please be aware of the potential instability of using alpha releases. You may also need to update your ESLint configuration file due to breaking changes in these packages.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix a security vulnerability (Uncontrolled Recursion, SNYK-JS-ESLINT-15102420) by upgrading ESLint from version 7.32.0 to 9.26.0. However, this is an incomplete upgrade that will break the project's linting functionality and CI pipeline.

Changes:

  • Upgrades eslint from ^7.5.0 to ^9.26.0 in package.json devDependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"@typescript-eslint/eslint-plugin": "^4.33.0",
"@typescript-eslint/parser": "^4.31.1",
"eslint": "^7.5.0",
"eslint": "^9.26.0",
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading ESLint from version 7 to version 9 is a major breaking change that requires updating multiple dependencies and configuration files. The current TypeScript ESLint packages (@typescript-eslint/eslint-plugin@4.33.0 and @typescript-eslint/parser@4.31.1) are incompatible with ESLint 9.x, which requires @typescript-eslint version 8 or later. Additionally, ESLint 9.x uses a new flat config format (eslint.config.js) instead of the old .eslintrc.js format currently used in this project. This upgrade will break the linting process and CI pipeline. To properly upgrade to ESLint 9, you need to also upgrade the TypeScript ESLint packages and migrate the configuration file to the new flat config format.

Suggested change
"eslint": "^9.26.0",
"eslint": "^7.32.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants