feat(gitlab): implement merge_after for automergeSchedule#37291
Open
dominikfoerster2003 wants to merge 5 commits intorenovatebot:mainfrom
Open
feat(gitlab): implement merge_after for automergeSchedule#37291dominikfoerster2003 wants to merge 5 commits intorenovatebot:mainfrom
dominikfoerster2003 wants to merge 5 commits intorenovatebot:mainfrom
Conversation
|
|
- Add automergeSchedule and timezone to PlatformPrOptions interface - Extend getPlatformPrOptions to pass schedule configuration to platforms - Modify GitLab tryPrAutomerge to set merge_after when outside schedule - Use existing getNextScheduleTime and isScheduledNow functions - Support both Cron and Later.js schedule syntax with timezone awareness - Add comprehensive documentation for the new functionality Closes renovatebot#37028
dominikfoerster2003
force-pushed
the
feat/gitlab-merge-after-schedule
branch
from
fd5bd35 to
3e17420
Compare
…implementation - Fix dependency cycle by moving schedule logic to getPlatformPrOptions - Fix TypeScript compilation errors in schedule.ts (croner API usage) - Fix import issue in bazel-module/extract.ts (upath -> node:path) - Update GitLab platform to use merge_after from platform options - Ensure all lint checks pass (ESLint, Prettier, markdown-lint) The implementation now properly integrates automergeSchedule with GitLab's merge_after parameter to prevent merges outside configured schedules. Fixes renovatebot#37028
- revert unrelated upath -> node:path change in bazel-module/extract.ts - remove spurious blank line in gitlab/index.ts imports - use Record<string, unknown> instead of any for requestBody - drop unused automergeSchedule/timezone fields from PlatformPrOptions - fix later.js next(1) returning Date instead of Date[] in getNextScheduleTime - add tests for getNextScheduleTime covering null cases, later.js schedules, cron schedules, multiple schedules, timezone and schedule key parameter
- resolve conflict in pr/index.ts (keep getNextScheduleTime import, adopt .ts extensions) - update is.array() -> isArray() after upstream switched to named import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: