feat(managers/npm): allow specifying toolSettings.nodeMaxMemory#40957
feat(managers/npm): allow specifying toolSettings.nodeMaxMemory#40957jamietanna wants to merge 1 commit intomainfrom
toolSettings.nodeMaxMemory#40957Conversation
RahulGautamSingh
left a comment
There was a problem hiding this comment.
feat(managers/npm) 😅
toolSettings.nodeMaxMemorytoolSettings.nodeMaxMemory
viceice
left a comment
There was a problem hiding this comment.
i maybe need to fix containerbase, the shell wrapper currently uses NODE_OPTIONS=--use-openssl-ca 🤔
this env would override it
| { | ||
| name: 'nodeMaxMemory', | ||
| description: | ||
| 'Maximum memory in MiB for Node child processes invoked by Renovate. If unset, the Node process will automagically determine the memory limit to use. Repo configuration for this value will be ignored if it exceeds the global configuration for `toolSettings.nodeMaxMemory`', |
There was a problem hiding this comment.
Don't duplicate this text in docs file above. this will also be added to the docs automatically.
There was a problem hiding this comment.
I prefer a bit more docs wise, as these then go into the JSON Schema, but can trim it down, if you'd prefer?
There was a problem hiding this comment.
then ttim the markdown file, not this option here, so we don't duplicate in docs.
There was a problem hiding this comment.
then ttim the markdown file, not this option here, so we don't duplicate in docs.
|
Re Containerbase: containerbase/base#5962 |
cc01f1f to
c4057eb
Compare
09e7de9 to
929bbd9
Compare
As noted in #40942, we're seeing an increase in memory usage across `pnpm` and `yarn` users in Mend-hosted apps. To allow limiting the maximum memory that any `node` child processes will use, we can add a new `toolSettings.nodeMaxMemory` to (hopefully) mitigate this. Similar to the `toolSettings.jvmMaxMemory`, the self-hosted administrator can set a maximum, which cannot be exceeded by repo-level configuration.
929bbd9 to
55a1e50
Compare
seen, it's not working as expected. will answer on PR why. |
Changes
As noted in #40942, we're seeing an increase in memory usage across
pnpmandyarnusers in Mend-hosted apps.To allow limiting the maximum memory that any
nodechild processeswill use, we can add a new
toolSettings.nodeMaxMemoryto (hopefully)mitigate this.
Similar to the
toolSettings.jvmMaxMemory, the self-hostedadministrator can set a maximum, which cannot be exceeded by repo-level
configuration.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
Warning
TODO
I have verified these changes via:
The public repository: