Skip to content

Conversation

@jonahsnider
Copy link

@jonahsnider jonahsnider commented Feb 6, 2026

Changes

Adds an Error Prone monorepo for the google/error-prone repo.

Error Prone releases versions of all their packages at once, with a single version for all of them (example). A typical Java codebase using Error Prone has dependencies on com.google.errorprone:error_prone_annotations and com.google.errorprone:error_prone_core (and occasionally com.google.errorprone:error_prone_refaster).

Context

Please select one of the following:

  • This closes an existing Issue
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

I used AI to make the change to group.preset.ts.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

@github-actions github-actions bot requested a review from viceice February 6, 2026 22:19
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please expand pr description why those should be grouped.

prefer grouping via monorepo.json if possible

@jonahsnider
Copy link
Author

please expand pr description why those should be grouped.

Error Prone releases versions of all their packages at once, with a single version for all of them (example). A typical Java codebase using Error Prone has dependencies on com.google.errorprone:error_prone_annotations and com.google.errorprone:error_prone_core (and occasionally com.google.errorprone:error_prone_refaster).

prefer grouping via monorepo.json if possible

Done

@jonahsnider jonahsnider requested a review from viceice February 7, 2026 18:14
@viceice viceice added the auto:no-done-comments Don't say "Done" or "Please review" - request a review instead label Feb 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

Hi there,

You are using done comments which cause a lot of noise/notifications. Instead, please use GitHub's web interface to request another review. Please read our contributing guidelines to reduce noise.

Good luck,

The Renovate team

@viceice
Copy link
Member

viceice commented Feb 8, 2026

please expand pr description why those should be grouped.

Error Prone releases versions of all their packages at once, with a single version for all of them (example). A typical Java codebase using Error Prone has dependencies on com.google.errorprone:error_prone_annotations and com.google.errorprone:error_prone_core (and occasionally com.google.errorprone:error_prone_refaster).

move this to PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:no-done-comments Don't say "Done" or "Please review" - request a review instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants