feat: add cake-sdk manager for Cake.Sdk build scripts#41270
feat: add cake-sdk manager for Cake.Sdk build scripts#41270devlead wants to merge 1 commit intorenovatebot:mainfrom
Conversation
|
|
|
See now this might duplicate efforts in #40070 |
viceice
left a comment
There was a problem hiding this comment.
shouldn't this added to the existing cake manager? 🤔
|
feel free to take over #40070 |
5438c6d to
9156380
Compare
Cake.Sdk uses a different runtime, file extension, and not the same preprocessor directives, so it felt cleaner not to merge with the existing Cake.Tool (cake manager) implementation. Addressed feedback, tested dry run, and against a real repo |
|
Hi @devlead, I just saw this PR and wanted to point to the PRs #40070 (which I think you already saw), and #40040. Both PRs together would cover the functionality of this PR if I saw that correctly. I just wanted to explain my reasoning for those PRs. #40040 extends the nuget manager because in my opinion the #40070 extends the existing cake manager to also include the |
9156380 to
f9b9d5b
Compare
I missed checking existing PRs; that's on me, so I've got no issue with this being closed in favor of those PRs, or if anything in this can be merged into those, feel free to copy, no attribution needed. Or if maintainers want me to adjust anything, I'll do so. |
- Add cake-sdk manager for cake.cs/build.cs (Cake.Sdk file-based scripts) - Extract #:sdk, #:package, and InstallTool(s) with nuget/dotnet URL format - Match (cake|build).cs by default; document opt-in for all .cs via managerFilePatterns - Register in api.ts; add fixtures, tests, and readme
f9b9d5b to
a483f2a
Compare
Changes
Adds a new cake-sdk manager so Renovate can update dependencies in Cake.Sdk build scripts (file-based
.csscripts), in addition to the existing cake manager for Cake.Tool (.cakefiles).cake.csandbuild.csonly. Opt-in to all.csfiles is documented viamanagerFilePatterns.#:sdk Cake.Sdk@version,#:package PackageName@version, andInstallTool/InstallToolswithnuget:/dotnet:URLs (same format as Cake.Tool tool directives).lib/modules/manager/cake-sdk/withextractPackageFile, fixtures, and unit tests; registered inlib/modules/manager/api.ts.lib/modules/manager/cake-sdk/readme.mddescribes supported syntax and the opt-in for all.csfiles.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Used Cursor for the cake-sdk manager implementation, tests, fixtures, and readme. Approach and structure were discussed; final edits, integration tests and PR text by me.
Documentation (please check one with an [x])
(Manager readme in
lib/modules/manager/cake-sdk/readme.md.)How I've verified my work (please select one)
I have verified these changes via:
The public repository:
Real repo tests
Dry run
Dry run with
node dist/renovate.js devlead/blobify --dry-run=fullconfirmed cake-sdk matchedcake.csand extracted Cake.Sdk, GitVersion.Tool, and DPI.Given / When
node dist/renovate.js devlead/blobify --dry-run=full --git-author 'Mattias Karlsson <1647294+devlead@users.noreply.github.com>'Then
Production Run
Given
Then
PRs Created