Skip to content

fix(config): warn if registryUrls is set at top-level in config#41682

Merged
viceice merged 5 commits intorenovatebot:mainfrom
RahulGautamSingh:fix-41663
Mar 5, 2026
Merged

fix(config): warn if registryUrls is set at top-level in config#41682
viceice merged 5 commits intorenovatebot:mainfrom
RahulGautamSingh:fix-41663

Conversation

@RahulGautamSingh
Copy link
Collaborator

Changes

Context

Please select one of the following:

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@github-actions github-actions bot requested a review from viceice March 5, 2026 05:41
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not what I had in my mind to fix the issue. it's nearly same as the original PR, where I told that's the wrong solution.

there should be config validation warning instead to not use registry urls at top level config.

later it should be an error because it will almost always cause errors

@jamietanna jamietanna closed this Mar 5, 2026
@RahulGautamSingh RahulGautamSingh changed the title fix(datasource/graphql): prevent calling non-github urls fix(datasource/graphql): prevent calling non-github urls [WIP] Mar 5, 2026
@RahulGautamSingh RahulGautamSingh requested a review from viceice March 5, 2026 10:11
@RahulGautamSingh RahulGautamSingh changed the title fix(datasource/graphql): prevent calling non-github urls [WIP] fix(config): warn if registryUrls is set at top-level in config Mar 5, 2026
Copy link
Contributor

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to warn if defaultRegistryUrls

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add same for defaultRegistryUrls

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why duplicate tests?

@RahulGautamSingh
Copy link
Collaborator Author

why duplicate tests?

one for global config test another for repo config

@RahulGautamSingh RahulGautamSingh requested a review from viceice March 5, 2026 18:21
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I don't see a benefit because the check is always done but ok

@viceice viceice added this pull request to the merge queue Mar 5, 2026
Merged via the queue into renovatebot:main with commit bfc3391 Mar 5, 2026
45 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🎉 This PR is included in version 43.56.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a config warning when overriding manager registryUrls

3 participants