Open
Conversation
renpytom
reviewed
Jul 13, 2025
| project(${SKBUILD_PROJECT_NAME} LANGUAGES C) | ||
|
|
||
| # Find required packages | ||
| find_package(Python 3.12 EXACT REQUIRED |
Member
There was a problem hiding this comment.
Is there a reason why we're using Python 3.12, only, rather than letting the build system supply the version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes build process from setuptools to scikit-build-core, where actual build is done by cmake/ninja.
This makes build instructions more straight forward, builds faster and simplifies needed configuration for MSYS.
I dropped paths for Python <3.12. And also STATIC build, as it could be done differently and simpler, when pygame is part of main repo.
If we want to merge it in, I could add documentation on what system libs should be installed (linux and msys), and after libs are installed, simple
uv build --wheelwill produce wheel that could be installed and imported on that machine (but no cross compilation or statically compiled libraries).