Closed
Conversation
cb341
requested changes
Jul 28, 2025
Contributor
cb341
left a comment
cb341
left a comment
There was a problem hiding this comment.
I don't quite follow this change..
Can you please describe what name may be outdated and why in the PR?
cb341
reviewed
Jul 30, 2025
Co-authored-by: Daniel Bengl <53896675+CuddlyBunion341@users.noreply.github.com>
cb341
approved these changes
Jul 31, 2025
Contributor
Author
|
Nvm, Raphael cleared it up. Apparently its need for automatic merges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, I think this entire step might be redundant.
When you configure Semaphore CI (following the "Configure the CI" section of the guide), it automatically:
Integrates with GitHub
Creates the status check ci/semaphoreci/push: [project-name]
Reports the check status on every PR
You don't need to manually add any status check requirements in the GitHub branch protection rules because it's already handled by the Semaphore integration.
Even without the configuration, the Semaphore check still happens:
Sorry for being unclear!