Conversation
In khw we use ticket references in our Depfu configuration: renuo/khw2#606 I propose that we set the reference by default.
| In order to avoid searching for the maintenance project after reviewing a Depfu PR, | ||
| we add the ticket to the PR title according to the following Depfu configuration: | ||
|
|
||
|  |
There was a problem hiding this comment.
Just in the title not in the branch name? Probably to spamy to have it linked in the redmine issue. So good as it is 👍
There was a problem hiding this comment.
Exactly.
Redmine linking works from the branch name and PR body so including it in the title shouldn't autolink it.
It is debatable whether or not we want to track security update releases on redmine or not.
I just want to make it easier to review depfu PRs by directly including the Redmine ticket in the PR title.
| * <https://github.com/heroku/heroku-buildpack-nodejs> | ||
| * <https://github.com/heroku/heroku-buildpack-ruby> | ||
| - <https://github.com/heroku/heroku-buildpack-nodejs> | ||
| - <https://github.com/heroku/heroku-buildpack-ruby> |
There was a problem hiding this comment.
Don't we have linting for this stuff?
There was a problem hiding this comment.
We have a markdown linter.
We also don't disable the Rule 004
But by default it prevents markdown list definitions such as:
* <https://github.com/heroku/heroku-buildpack-nodejs>
- <https://github.com/heroku/heroku-buildpack-ruby>But we don't enforce a specific style.
I'd expect a .mdlrc like this:
rule "MD004", style: :dash
rules "~MD013", "~MD026", "~MD029", "~MD032", "~MD036", "~MD002", "~MD034", "~MD031", "~MD028", "~MD027"
git_recurse trueTo convert all bullets to dashes but I can't figure out why it doesn't work.
2 participants
In khw we use ticket references in our Depfu configuration: https://github.com/renuo/khw2/pull/606
I propose that we set the reference by default.