Update RSpec guide #428
Update RSpec guide #428
Conversation
This time in the correct branch xd
rnestler
left a comment
rnestler
left a comment
There was a problem hiding this comment.
I'm not sure I like this a lot. With newer defaults in the rspec gem this will be outdated faster, then if we just add our options separately.
We could add a short reminder for users to inspect changes with |
coorasse
left a comment
coorasse
left a comment
There was a problem hiding this comment.
I am also not much in favour. I think is better to add smaller bits. I'd rather remove the spec helper template.
I added back the incremental snippets together with the the configurations from the template files |
ruby_on_rails/rspec.md
Outdated
| add_filter "app/mailers/application_mailer.rb" | ||
| add_filter "app/models/application_record.rb" | ||
| add_filter ".semaphore-cache" | ||
| SimpleCov.start 'rails' do |
There was a problem hiding this comment.
our new standard is double quotes, so I'd use double quotes here as well
This time in the correct branch xd
ddbrendan
force-pushed
the
Update-RSpec-guide
branch
from
c22084a to
c0db5e6
Compare
…tions-setup-guide into Update-RSpec-guide
The RSpec configuration guide previously showed partial configuration snippets and instructed users to "check the template" for complete configurations. This required users to manually merge configurations from both the guide and the template files, which was confusing.
I updated the guide to include full configurations directly on the page. Users can now simply copy and paste the entire configuration blocks to replace their files without any manual merging.