Merged
Conversation
Contributor
Author
|
@coorasse I'm not sure about the fixes in bin/super_grep and bin/super_ripgrep but this made the tests to pass. Happy to discuss with you 👍 |
coorasse
reviewed
Jan 30, 2026
Member
coorasse
left a comment
coorasse
left a comment
There was a problem hiding this comment.
It's all good except the changes to bin/super_grep and bin/super_ripgrep. May you extract these two in a separate PR? So we can merge this one, with everything else, and we look at the changes to these two files separately
Contributor
Author
|
Okay lets extract those bin changes to another script and we can see how this can be solved in another way 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failing linter and tests
NOTE: 2 tests still failing but will be investigated in another PR